SQL Injection

This reverts commit d1b0b9476b.

.github/workflows/plexalyzer-scan.yml

@@ -1,36 +0,0 @@
-name: PLEXALYZER Analysis
-on:
-  pull_request:
-    types: [opened, synchronize]
-
-jobs:
-  analyze:
-    if: ${{ !startsWith(github.head_ref, 'Plexicus-AI-Remediation-') }}
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Get Changed Files and Save to File
-        id: get_changed_files
-        shell: bash
-        run: |
-          # Capture changed files and save to a temporary file
-          changed_files=$(git diff --name-only "${{ github.event.pull_request.base.sha }}" "${{ github.event.pull_request.head.sha }}")
-          echo "$changed_files" | jq -R -s -c 'split("\n")[:-1]' > files_to_scan.json
-          echo "files_path=$(pwd)/files_to_scan.json" >> $GITHUB_ENV
-
-      - name: Run PLEXALYZER Analysis
-        uses: plexicus/plexicus-action@dev
-        with:
-          plexalyzer-token: ${{ secrets.PLEXALYZER_TOKEN }}
-          default-owner: ${{ github.event.repository.owner.login }}
-          repo-id: ${{ vars.COVULOR_REPO_ID }}
-          repo-name: ${{ github.repository }}
-          branch: ${{ github.event.pull_request.base.ref }}
-          url: ${{ github.event.repository.clone_url }}
-          pr-id: ${{ github.event.pull_request.number }}
-          files-path: ${{ env.files_path }}
-          workspace-path: ${{ github.workspace }}

index.php

@@ -13,39 +13,37 @@ if ($conn->connect_error) {
     die("Conexión fallida: " . $conn->connect_error);
 }
 
-/*
-Brief analysis - ALEX:
-This change fixes a SQL Injection vulnerability by using a parameterized prepared statement and strict validation of the 'id' parameter.
-I will replace the concatenated SQL with a mysqli prepared statement binding the id as an integer; only index.php is modified.
-*/
+// Vulnerabilidad de SQL Injection
+// El siguiente código es vulnerable a SQL Injection ya que el input del usuario se concatena directamente en la consulta SQL sin validación o sanitización.
 if(isset($_GET['id'])) {
     $id = $_GET['id']; // Input del usuario tomado directamente desde la URL
-
-    // Whitelist/validate: allow only digits to prevent injection
-    if (!preg_match('/^\d+$/', $id)) {
-        echo "Invalid id";
+    // Validate that id is an integer (whitelist) before using it in a query
+    if (filter_var($id, FILTER_VALIDATE_INT) === false) {
+        echo "Entrada 'id' inválida";
     } else {
-        $id_int = (int)$id;
-
+        $id = (int)$id;
         // Use a prepared statement to avoid SQL injection
-        $stmt = $conn->prepare("SELECT id, nombre FROM usuarios WHERE id = ?");
+        $stmt = $conn->prepare("SELECT * FROM usuarios WHERE id = ?");
         if ($stmt) {
-            $stmt->bind_param("i", $id_int);
+            $stmt->bind_param("i", $id);
             $stmt->execute();
             $result = $stmt->get_result();
 
-            if ($result && $result->num_rows > 0) {
+            if ($result === false) {
+                echo "Error en la consulta";
+            } else {
+                if ($result->num_rows > 0) {
                     while($row = $result->fetch_assoc()) {
                         echo "id: " . $row["id"]. " - Nombre: " . $row["nombre"]. "<br>";
                     }
                 } else {
                     echo "0 resultados";
                 }
+            }
 
             $stmt->close();
         } else {
-            // Do not execute an unsafe query if prepare() failed
-            echo "Query preparation failed";
+            echo "Error al preparar la consulta";
         }
     }
 }